Bug Fix: DataTransformer returning same class as original should include JSONLD Data #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver to avoid overflow during BAN command
Add entrypoints sorting
Feat: remove template pull request
* Add defaults configuration * Suggest defaults in configuration * Apply changes from code review * Add deprecation notices for legacy defaults * Apply @dunglas' suggestions
Merge 2.5 into master
This makes it more clear this interface can be 'caught'
Use https instead of http
Make the base exception extend throwable
* 2.5: Fix spelling Fix removal of illegal characters in schema name for Amazon API Gateway Add links to documentation to ApiResource properties fix #3189 - JSONAPI pagination ignored when using filter parameter
This will allow IDEs to provide hints/ autocompletion
More Descriptive Input/Output class names
* 2.5: Update CHANGELOG.md [GraphQL] Better detection of collection types (#3327) Add tests for building JSON Schema of non-resource class Fix JSON Schema generation for non-resource class
* Subscription support * Use sha256 hash for generating subscription identifiers * Update CHANGELOG
…mation-in-contributing fix outdated pull request template link in contribution guide
…tions Add specification property field's values restrictions based on validator setting
Merge 2.5 into master
Merge 2.5 into master
Co-authored-by: Teoh Han Hui <teohhanhui@gmail.com>
Allow to autoconfigure validation groups generators
… error codes during normalization of errors. #2922
Co-Authored-By: Teoh Han Hui <teohhanhui@gmail.com>
Add error code for JsonApi errors.
Co-Authored-By: Teoh Han Hui <teohhanhui@gmail.com>
send Varnish BAN requests with smaller headers
add support for stale-while-revalidate and stale-if-error cache-control extensions
Merge 2.5
In `ApiPlatform\Core\DataTransformer\DataTransformerInterface` there is a comment that states that DTOs should be allowed to return the same original object if no transformation is done. Ths resulted in missing LD data. (No @id, @context etc.). ```php /** * Transforms the given object to something else, usually another object. * This must return the original object if no transformation has been done. * * @param object $object * * @return object */ public function transform($object, string $to, array $context = []); ``` This update checks if the output class is the same as the original, and if so populated the extended metadata in the JsonLd\ItemNormalizer as it would not be added using the JsonLd\ObjectNormalizer
|
Sorry will re-do patch done on the 2.5 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry but I'm very bad with tests so have not written one and do not know where it'd be best placed.
In
ApiPlatform\Core\DataTransformer\DataTransformerInterfacethere is a comment that states that DTOs should be allowed to return the same original object if no transformation is done. This resulted in missing LD data. (No @id, @context etc.).This update checks if the output class is the same as the original, and if so populated the extended metadata in the JsonLd\ItemNormalizer as it would not be added using the JsonLd\ObjectNormalizer