Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add messenger=persist #3617

Merged
merged 8 commits into from
Sep 25, 2020
Merged

Add messenger=persist #3617

merged 8 commits into from
Sep 25, 2020

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Jun 22, 2020 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tickets fixes #3371
License MIT
Doc PR api-platform/docs#1132
  • Support for "persist" and array value on messenger attribute
  • Update unit tests
  • Add functional tests
  • Add doc PR

soyuka
soyuka reviewed Jun 22, 2020
View reviewed changes
Copy link
Member

@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I prefer this implementation. Note that there may be instances of the getAttribute('messenger') accross the code that'd need to be changed to support an array (DataTransformer for example).

src/Bridge/Symfony/Messenger/DataPersister.php Show resolved Hide resolved
@vincentchalamon vincentchalamon force-pushed the issues/3371 branch 2 times, most recently from 15de913 to ae82685 Compare June 22, 2020 15:11
@vincentchalamon vincentchalamon mentioned this pull request Jun 25, 2020
Merged
@vincentchalamon vincentchalamon marked this pull request as ready for review June 25, 2020 07:52
@vincentchalamon vincentchalamon force-pushed the issues/3371 branch 2 times, most recently from 8986e05 to fa0e3aa Compare June 25, 2020 08:32
@vincentchalamon vincentchalamon self-assigned this Jun 25, 2020
@vincentchalamon vincentchalamon force-pushed the issues/3371 branch 3 times, most recently from 329c5a2 to 53bbf18 Compare June 25, 2020 09:36
@vincentchalamon vincentchalamon force-pushed the issues/3371 branch 5 times, most recently from 2e7bfa8 to 0298271 Compare June 25, 2020 10:14
@vincentchalamon vincentchalamon force-pushed the issues/3371 branch 2 times, most recently from cf7a806 to a055b1d Compare July 25, 2020 07:34
@soyuka soyuka merged commit ce06420 into api-platform:master Sep 25, 2020
@soyuka
Copy link
Member

soyuka commented Sep 25, 2020

Thanks @vincentchalamon !

@vincentchalamon vincentchalamon deleted the issues/3371 branch September 25, 2020 10:13
soyuka added a commit to soyuka/core that referenced this pull request Dec 17, 2020
@soyuka
Revert "Add messenger=persist (api-platform#3617)"
797f186 
This reverts commit ce06420.
soyuka added a commit to soyuka/core that referenced this pull request Dec 17, 2020
@soyuka
Revert "Add messenger=persist (api-platform#3617)"
396b4c3 
This reverts commit ce06420.
@soyuka soyuka mentioned this pull request Dec 17, 2020
Merged
soyuka added a commit to soyuka/core that referenced this pull request Dec 17, 2020
@soyuka
Revert "Add messenger=persist (api-platform#3617)"
bb0a025 
This reverts commit ce06420.
soyuka added a commit to soyuka/core that referenced this pull request Dec 17, 2020
@soyuka
Revert "Add messenger=persist (api-platform#3617)"
d92f134 
This reverts commit ce06420.
soyuka added a commit to soyuka/core that referenced this pull request Dec 17, 2020
@soyuka
Revert "Add messenger=persist (api-platform#3617)"
a166d15
soyuka added a commit that referenced this pull request Dec 19, 2020
@soyuka
Revert messenger=persist and introduce a ResumableDataPersisterInterf…
126e65d 
…ace (#3912)

* Revert "Add messenger=persist (#3617)"

* Add a ResumableDataPersisterInterface

* review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka soyuka approved these changes

@alanpoulain alanpoulain Awaiting requested review from alanpoulain

@dunglas dunglas Awaiting requested review from dunglas

Assignees

@vincentchalamon vincentchalamon

Labels
enhancement [RFR] Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal] Allow array in messenger attribute
4 participants
@vincentchalamon @soyuka @dunglas @alanpoulain