Revert messenger=persist and introduce a ResumableDataPersisterInterface #3912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/messenger-persist
branch
2 times, most recently
from
bb0a025 to
d92f134
Compare
vincentchalamon
requested changes
Dec 17, 2020
| if (!$match && $persister->supports($data, $context)) { | ||
| $match = $persister; | ||
| $this->persistersResponse[\get_class($persister)] = true; | ||
| if (($this->persistersResponse[\get_class($persister)] = $found ? false : $persister->supports($data)) && !($persister instanceof ResumableDataPersisterInterface && $persister->resumable()) && !$found) { |
There was a problem hiding this comment.
For readability, could you split this condition in multilines?
soyuka
force-pushed
the
fix/messenger-persist
branch
from
d92f134 to
0905bc5
Compare
vincentchalamon
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #3617