Escape search terms before using them in a Regex

[rimas-kudelis]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	yes: search terms no longer need or support explicit escaping, and consequently, regex special characters no longer behave like they're special.
Deprecations?	no
Tickets	Fixes #3754
License	MIT
Doc PR	N/A

[alanpoulain]

Thanks!
Could you add a unit test too?

[rimas-kudelis]

Thanks!
Could you add a unit test too?

Erm... if only I could understand how those tests work, or at least install composer dependencies...
I've added a new element to SearchFilterTest::provideApplyRestData(), but I strongly doubt that will be enough, will it? :)

EDIT: I've installed the dependencies, but how do I run the tests? Right now running ./vendor/bin/simple-phpunit fails a good bunch of them. Do I also need things like MySQL and MongoDB installed just to run them?

[soyuka]

You need the mongodb php extension only if you want to test mongodb stuff. See https://github.com/api-platform/core/blob/master/CONTRIBUTING.md#tests for more informations on how to run tests.

[rimas-kudelis]

I've added the test as requested.
Also added phpspec/prophecy to require-dev, because existing tests just failed without it.

[rimas-kudelis]

Are we still waiting for something?

[alanpoulain]

Thank you @rimas-kudelis!

[rimas-kudelis]

Thanks for merging! 👍