Fix tests #3791
Merged
Fix tests #3791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierredup
commented
Oct 26, 2020
| require end($phpunitInstalls).'/vendor/autoload.php'; | ||
| $phpunitLoader = require end($phpunitInstalls).'/vendor/autoload.php'; | ||
| $phpunitLoader->unregister(); | ||
| $phpunitLoader->register(); |
There was a problem hiding this comment.
This seems a bit hacky, but it's required in order to not prepend the PHPUnit autoloader, as it is registered before the normal autoloader. So this causes issues specifically with the Composer\InstalledVersions class, which is loaded from the vendor/.phpunit/8.3/vendor directory instead of the one in the standard vendor directory.
So here we need to unregister the autoloader and re-register it so that is it appended to the queue
dunglas
approved these changes
Oct 26, 2020
|
Thanks @pierredup! It's very much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current failing tests