Skip to content

fix warning for preloading AbstractPaginator class #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Dec 10, 2020
Merged

fix warning for preloading AbstractPaginator class #3827

merged 1 commit into from Dec 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 13, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tickets
License MIT
Doc PR

This pull requests should fix a php warning when opcache preload is active:

PHP Warning:  Can't preload unlinked class class@anonymous: Unknown parent ApiPlatform\\Core\\Bridge\\Doctrine\\Orm\\AbstractPaginator in /app/vendor/api-platform/core/src/Bridge/Doctrine/Orm/Extension/PaginationExtension.php on line 178

This fix uses the solution of symfony/symfony#38533.

alanpoulain
alanpoulain approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@alanpoulain alanpoulain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soyuka soyuka mentioned this pull request Nov 27, 2020
Closed
@dunglas dunglas merged commit 29cd84b into api-platform:2.5 Dec 10, 2020
@dunglas
Copy link
Member

dunglas commented Dec 10, 2020

Thanks @optior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dunglas @alanpoulain