Skip to content

CI: Set-env is deprecated #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2020
Merged

CI: Set-env is deprecated #3835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a54c91f
CI: Set-env is deprecated
soyuka Nov 17, 2020
3fe4bcc
fix phpstan
soyuka Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ jobs:
restore-keys: ${{ runner.os }}-composer-
- name: Enable code coverage
if: matrix.coverage
run: echo '::set-env name=COVERAGE::1'
run: echo "COVERAGE=1" >> $GITHUB_ENV
- name: Remove Doctrine MongoDB ODM
if: (startsWith(matrix.php, '7.1') || startsWith(matrix.php, 'rc'))
run: |
Expand Down Expand Up @@ -222,7 +222,7 @@ jobs:
restore-keys: ${{ runner.os }}-composer-
- name: Enable code coverage
if: matrix.coverage
run: echo '::set-env name=COVERAGE::1'
run: echo "COVERAGE=1" >> $GITHUB_ENV
- name: Remove Doctrine MongoDB ODM
if: startsWith(matrix.php, '7.1')
run: |
Expand Down
16 changes: 8 additions & 8 deletions tests/JsonLd/Serializer/ObjectNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ public function testNormalize()
'@id' => '_:1234',
]);

$normalizer = new ObjectNormalizer( // @phpstan-ignore-line
$serializerProphecy->reveal(),
$normalizer = new ObjectNormalizer(
$serializerProphecy->reveal(), // @phpstan-ignore-line
$iriConverterProphecy->reveal(),
$contextBuilderProphecy->reveal()
);
Expand Down Expand Up @@ -77,8 +77,8 @@ public function testNormalizeEmptyArray()
$contextBuilderProphecy = $this->prophesize(AnonymousContextBuilderInterface::class);
$contextBuilderProphecy->getAnonymousResourceContext($dummy, Argument::type('array'))->shouldNotBeCalled();

$normalizer = new ObjectNormalizer( // @phpstan-ignore-line
$serializerProphecy->reveal(),
$normalizer = new ObjectNormalizer(
$serializerProphecy->reveal(), // @phpstan-ignore-line
$iriConverterProphecy->reveal(),
$contextBuilderProphecy->reveal()
);
Expand All @@ -101,8 +101,8 @@ public function testNormalizeWithOutput()
$contextBuilderProphecy = $this->prophesize(AnonymousContextBuilderInterface::class);
$contextBuilderProphecy->getAnonymousResourceContext($dummy, ['iri' => '/dummy/1234', 'api_resource' => $dummy])->shouldBeCalled()->willReturn(['@id' => '/dummy/1234', '@type' => 'Dummy', '@context' => []]);

$normalizer = new ObjectNormalizer( // @phpstan-ignore-line
$serializerProphecy->reveal(),
$normalizer = new ObjectNormalizer(
$serializerProphecy->reveal(), // @phpstan-ignore-line
$iriConverterProphecy->reveal(),
$contextBuilderProphecy->reveal()
);
Expand Down Expand Up @@ -131,8 +131,8 @@ public function testNormalizeWithContext()
$contextBuilderProphecy = $this->prophesize(AnonymousContextBuilderInterface::class);
$contextBuilderProphecy->getAnonymousResourceContext($dummy, ['iri' => '/dummy/1234', 'api_resource' => $dummy, 'has_context' => true])->shouldBeCalled()->willReturn(['@id' => '/dummy/1234', '@type' => 'Dummy']);

$normalizer = new ObjectNormalizer( // @phpstan-ignore-line
$serializerProphecy->reveal(),
$normalizer = new ObjectNormalizer(
$serializerProphecy->reveal(), // @phpstan-ignore-line
$iriConverterProphecy->reveal(),
$contextBuilderProphecy->reveal()
);
Expand Down