-
-
Notifications
You must be signed in to change notification settings - Fork 933
[DoctrineBridge][UX] Better Doctrine exceptions #3965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
87889be
to
bb4eba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, can you modify the CHANGELOG too?
It will be merged after the 2.6 release.
It seems test failures are related. |
100a9c2
to
94af267
Compare
54ceb14
to
4744153
Compare
4744153
to
5aa84f7
Compare
29406ba
to
6940916
Compare
6693a87
to
c1f8d55
Compare
After some thinking, shouldn't we just use: (new \ReflectionClass($resourceClass))->getShortName(); instead of introducing a new dependency? |
Since we can modify resource short-name, it's possible it won't be the same as given in related resource. I think we need this dependency here. |
Thank you @Korbeil. |
I had some issues to understand this error with some entities that have a lot of sub-entities. To make this easier to understand, just add the resource to the exception and it became way easier 😄