Skip to content

Fix: allow to disable OpenAPI, Swagger UI #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2021
Merged

Fix: allow to disable OpenAPI, Swagger UI #3968

merged 4 commits into from
Jan 30, 2021

Conversation

GrimpEreau
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tickets fixes #3960
License MIT
Doc PR n/a

@alanpoulain
Copy link
Member

Should we really load all the Swagger services all the time? I'm not sure it's the right fix.

@dunglas dunglas requested a review from soyuka January 22, 2021 09:09
@soyuka
Copy link
Member

soyuka commented Jan 22, 2021

We discussed this and this still requires changes:

  • schema factory must be loaded even when swagger is disabled
  • disabling swagger should disable swagger ui
  • DocumentationAction has a dependency to openapi that needs the on-invalid=ignore flag

Base automatically changed from master to main January 23, 2021 21:59
@GrimpEreau GrimpEreau force-pushed the fix/issue-3960 branch 2 times, most recently from efcab4c to 19b08ef Compare January 26, 2021 14:20
@BeyerJC BeyerJC mentioned this pull request Jan 29, 2021
Closed
@soyuka soyuka merged commit 41842c4 into api-platform:main Jan 30, 2021
@soyuka
Copy link
Member

soyuka commented Jan 30, 2021

thanks @GrimpEreau !

@soyuka soyuka mentioned this pull request Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soyuka soyuka soyuka left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not possible to disable OpenAPI, swagger UI

3 participants

@GrimpEreau @alanpoulain @soyuka