fix pagination defaults and add tests #4011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GrimpEreau
commented
Feb 2, 2021
GrimpEreau
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | fixes #3992 |
| License | MIT |
| Doc PR | n/a |
alanpoulain
reviewed
Feb 2, 2021
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
soyuka
reviewed
Feb 2, 2021
| $container->setParameter('api_platform.collection.order', $config['defaults']['order'] ?? $config['collection']['order']); | ||
| $container->setParameter('api_platform.collection.order_parameter_name', $config['collection']['order_parameter_name']); | ||
| $container->setParameter('api_platform.collection.pagination.enabled', $this->isConfigEnabled($container, $config['defaults']['pagination_enabled'] ?? $config['collection']['pagination'])); | ||
| $container->setParameter('api_platform.collection.pagination.enabled', $config['api_platform']['defaults'] ?? $this->isConfigEnabled($container, $config['collection']['pagination'])); |
There was a problem hiding this comment.
Suggested change
| $container->setParameter('api_platform.collection.pagination.enabled', $config['api_platform']['defaults'] ?? $this->isConfigEnabled($container, $config['collection']['pagination'])); | |
| $container->setParameter('api_platform.collection.pagination.enabled', $config['api_platform']['defaults']['pagination_enabled'] ?? $this->isConfigEnabled($container, $config['collection']['pagination'])); |
soyuka
reviewed
Feb 2, 2021
| 'attributes' => [ | ||
| 'pagination' => true, | ||
| ], | ||
| ]; |
There was a problem hiding this comment.
It should be:
$config['api_platform']['defaults'] = [
'pagination_enabled' => true
];
GrimpEreau
force-pushed
the
fix/issue-3992
branch
from
48ec4ae to
b3b7e7a
Compare
GrimpEreau
force-pushed
the
fix/issue-3992
branch
from
b3b7e7a to
a216e8b
Compare
soyuka
approved these changes
Feb 3, 2021
alanpoulain
approved these changes
Feb 3, 2021
|
thanks @GrimpEreau ! |
cacahouwete
pushed a commit
to cacahouwete/core
that referenced
this pull request
Feb 8, 2021
* fix pagination defaults and add tests * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.