Add support for generating property schema with Range restriction #4158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Mar 25, 2021
src/Bridge/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaRangeRestriction.php
Outdated
Show resolved
Hide resolved
|
However, this is a new feature. Could you target the |
|
previous similar PR's were merged as a bugfixes :/ |
norkunas
force-pushed
the
property-schema-range-restriction
branch
from
81faeb0 to
4f20503
Compare
Yes, for reference: #4139 (comment). Could you add a CHANGELOG entry too? |
norkunas
force-pushed
the
property-schema-range-restriction
branch
from
4f20503 to
e1d443c
Compare
Sure, added. |
soyuka
force-pushed
the
property-schema-range-restriction
branch
from
e1d443c to
906b385
Compare
norkunas
force-pushed
the
property-schema-range-restriction
branch
from
906b385 to
ba3cd8d
Compare
norkunas
changed the title
alanpoulain
reviewed
Mar 25, 2021
src/Bridge/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaRangeRestriction.php
Outdated
Show resolved
Hide resolved
norkunas
force-pushed
the
property-schema-range-restriction
branch
from
ba3cd8d to
4aa39e1
Compare
norkunas
force-pushed
the
property-schema-range-restriction
branch
from
4aa39e1 to
2d84672
Compare
alanpoulain
approved these changes
Mar 26, 2021
|
Thank you again @norkunas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
PropertySchemaRangeRestrictionto transform for integers and floats Range validation constraint intominimum/maximumJSON Schema restriction.