Fix #2686: deprecate allow_plain_identifiers option #4167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentchalamon
force-pushed
the
issues/2686
branch
2 times, most recently
from
46a4cd6 to
f477b4f
Compare
soyuka
reviewed
Mar 26, 2021
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php
Outdated
Show resolved
Hide resolved
vincentchalamon
force-pushed
the
issues/2686
branch
4 times, most recently
from
ec91287 to
f6c4deb
Compare
vincentchalamon
force-pushed
the
issues/2686
branch
3 times, most recently
from
b4804f6 to
e2b8db8
Compare
alanpoulain
reviewed
Apr 2, 2021
src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
alanpoulain
approved these changes
Apr 2, 2021
vincentchalamon
force-pushed
the
issues/2686
branch
from
91a00e0 to
e4e6d0c
Compare
|
thanks @vincentchalamon |
|
In my opinion we should still provide support for plain identifiers but as a normalizer/de normalizer decorator (that will simplify everything). |
|
@dunglas that's the goal of this PR in the documentation 😉: api-platform/docs#1326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.