Add support for generating property schema with Collection restriction #4182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about the implementation, suggestions welcome 😃 |
norkunas
force-pushed
the
property-schema-collection-restriction
branch
5 times, most recently
from
13bff4e to
d973db6
Compare
.../Symfony/Validator/Metadata/Property/Restriction/PropertySchemaCollectionRestrictionTest.php
Outdated
Show resolved
Hide resolved
norkunas
force-pushed
the
property-schema-collection-restriction
branch
from
d973db6 to
ded4dc5
Compare
...idge/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaCollectionRestriction.php
Outdated
Show resolved
Hide resolved
norkunas
force-pushed
the
property-schema-collection-restriction
branch
3 times, most recently
from
2141b27 to
c3b1344
Compare
|
phpstan failures are unrelated |
alanpoulain
reviewed
Apr 2, 2021
...idge/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaCollectionRestriction.php
Outdated
Show resolved
Hide resolved
norkunas
force-pushed
the
property-schema-collection-restriction
branch
2 times, most recently
from
1563b4d to
3f7204a
Compare
norkunas
force-pushed
the
property-schema-collection-restriction
branch
from
1aeee7d to
be30f17
Compare
alanpoulain
approved these changes
Apr 13, 2021
|
Thank you! |
|
Thanks for merging! |
This was referenced Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
PropertySchemaCollectionRestrictionto transform Collection validation constraint into json schema.