Add support for generating property schema format for Url and Hostname

[norkunas]

Q	A
Branch?	main
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	N/A
License	MIT
Doc PR	N/A

Add a PropertySchemaUrlRestriction to transform Url validation constraint into json schema.

[guilliamxavier]

Please remove me from the description 😆 I'm already checking https://github.com/api-platform/core/pulse from time to time these days (also I'm not part of the team)

If it may help: the test failure for "lowest" is related to symfony/validator@adab212 (introduced in v4.4.8)

But string manipulation and generating a huge pattern in the schema... is it really worth it? 🤔 Wouldn't it be enough to add something like this in the existing PropertySchemaFormat?

         if ($constraint instanceof Email) {
             return ['format' => 'email'];
         }
+
+        if ($constraint instanceof Url) {
+            return ['format' => 'uri'];
+        }
 
         if ($constraint instanceof Uuid) {
             return ['format' => 'uuid'];
         }

This would not be strictly equivalent (also ambiguity between "URL", "URI" and "URI reference"), but that's already true for Email (3 different validation modes)... Also Url is probably less used...

Anyway let's wait for a proper review from a team member 😄

[norkunas]

I just cc'ed because you were interested in these PR's :D

[norkunas]

IMHO if backend validates based on some pattern then it should be exposed nevertheless..

[norkunas]

Included also Hostname constraint as it's uri related

[alanpoulain]

I agree with @guilliamxavier. Since the format is used, I don't think it's a good idea to have the regexp as well.
Since URI is a specification, there should be no difference between the "client" regular expression and the backend one.

[norkunas]

But how would you distinguish then allowing only some other specific protocols?

[alanpoulain]

You would not be able to, that's right. Personally, I think it's a little bit too much detailed though. And the implementation is very dependent of the pattern in UrlValidator. If something change, it will break.
But maybe I'm wrong on this one. @soyuka, do you have an opinion on this matter?

[norkunas]

Removed the pattern part.

[soyuka]

Tyvm @norkunas !