Skip to content

Add XML and YAML support for new Resource attribute #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 28, 2021
Merged

Add XML and YAML support for new Resource attribute #4382

merged 25 commits into from
Dec 28, 2021

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Aug 17, 2021 •
edited
Loading

Q A
Branch? main
Tickets https://github.com/api-platform/core/projects/10#card-66986300
License MIT
Doc PR api-platform/docs#1473
  • resource/operations: defaults, requirements, options, status, schemes
  • properties: defaults, example, builtinTypes, schema
  • update doc (xml/yaml)
  • test that if a new attribute is added on ApiResource class, it must be added on XML (XmlAdapter)
  • test that if a new attribute is added on ApiResource class, it must be added on YAML (YamlAdapter)
  • fix tests

@vincentchalamon vincentchalamon self-assigned this Aug 17, 2021
@vincentchalamon vincentchalamon force-pushed the feat/xml-yaml-extractors branch 3 times, most recently from 84fe726 to 69716fe Compare August 20, 2021 12:53
soyuka
soyuka reviewed Aug 24, 2021
View reviewed changes
soyuka
soyuka reviewed Aug 24, 2021
View reviewed changes
soyuka
soyuka reviewed Aug 24, 2021
View reviewed changes
soyuka
soyuka reviewed Aug 24, 2021
View reviewed changes
@vincentchalamon vincentchalamon requested a review from soyuka August 24, 2021 14:46
@vincentchalamon vincentchalamon force-pushed the feat/xml-yaml-extractors branch 2 times, most recently from 85c9972 to 091f023 Compare August 27, 2021 17:03
@soyuka
Copy link
Member

soyuka commented Sep 2, 2021

https://github.com/api-platform/core/projects/10#card-66986300

@vincentchalamon vincentchalamon force-pushed the feat/xml-yaml-extractors branch 12 times, most recently from f46749c to bb142f8 Compare September 6, 2021 15:13
@vincentchalamon vincentchalamon force-pushed the feat/xml-yaml-extractors branch 4 times, most recently from 184f525 to 3ab23bd Compare October 1, 2021 09:09
@soyuka soyuka force-pushed the feat/xml-yaml-extractors branch from 82e3b40 to db4a720 Compare December 25, 2021 13:35
@soyuka soyuka force-pushed the feat/xml-yaml-extractors branch 2 times, most recently from 0acf1f5 to 5bf8684 Compare December 27, 2021 19:20
@soyuka soyuka force-pushed the feat/xml-yaml-extractors branch from 5bf8684 to a03e286 Compare December 27, 2021 20:44
soyuka
soyuka reviewed Dec 27, 2021
View reviewed changes
Copy link
Member

@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge work! Few comments.

@vincentchalamon vincentchalamon force-pushed the feat/xml-yaml-extractors branch from 77b1e74 to d2536da Compare December 28, 2021 09:52
@vincentchalamon vincentchalamon force-pushed the feat/xml-yaml-extractors branch from e6d6913 to 81bd436 Compare December 28, 2021 10:10
@soyuka soyuka merged commit 119b05b into api-platform:main Dec 28, 2021
@vincentchalamon vincentchalamon deleted the feat/xml-yaml-extractors branch December 28, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka soyuka approved these changes

Assignees

@vincentchalamon vincentchalamon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentchalamon @soyuka