feat(debug): add a debug resource command #4401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samuelbigard
commented
Aug 31, 2021
samuelbigard
commented
| Q | A |
|---|---|
| Branch? | main |
| Type | Feature |
| Tickets | |
| License | MIT |
samuelbigard
force-pushed
the
feat/debug-resource-command
branch
from
edeefa5 to
8e50f5a
Compare
soyuka
approved these changes
Aug 31, 2021
soyuka
force-pushed
the
feat/debug-resource-command
branch
from
8e50f5a to
0c7cdb9
Compare
dunglas
reviewed
Sep 1, 2021
samuelbigard
force-pushed
the
feat/debug-resource-command
branch
2 times, most recently
from
8f88ed1 to
af157d1
Compare
dunglas
requested changes
Sep 1, 2021
samuelbigard
force-pushed
the
feat/debug-resource-command
branch
2 times, most recently
from
44e7e1d to
8228db1
Compare
dunglas
reviewed
Sep 2, 2021
|
|
||
| public function testDebugResource() | ||
| { | ||
| $varDumper = $this->prophesize(CliDumper::class); |
There was a problem hiding this comment.
I think that it's not necessary to mock this class (don't mock what you don't own). You may just instantiate a CliDumper dumping to /dev/null.
This should do the trick.
Suggested change
| $varDumper = $this->prophesize(CliDumper::class); | |
| $varDumper = new CliDumper('Windows' === PHP_OS_FAMILY ? 'NUL' : '/dev/null'); |
There was a problem hiding this comment.
But we want to test that dump is called isn't that alright?
There was a problem hiding this comment.
We should at least mock the interface instead of a concretion in this case.
There was a problem hiding this comment.
Another option could be to set php://memory as output and to assert that something has been written in it.
samuelbigard
force-pushed
the
feat/debug-resource-command
branch
from
8228db1 to
b7a8662
Compare
dunglas
approved these changes
Sep 3, 2021
samuelbigard
force-pushed
the
feat/debug-resource-command
branch
from
b7a8662 to
b63200c
Compare
|
Thanks @samuelbigard ! |
vincentchalamon
pushed a commit
to vincentchalamon/core
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.