fix(doctrine): do not apply order extension if sorting already defined #4493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Oct 7, 2021
alanpoulain
reviewed
Oct 7, 2021
tests/Bridge/Doctrine/MongoDbOdm/Extension/OrderExtensionTest.php
Outdated
Show resolved
Hide resolved
soyuka
force-pushed
the
hotfix/do-not-apply-order-extension-if-not-needed
branch
from
5223f43 to
5a00b29
Compare
|
thanks @natepage ! |
|
@alanpoulain @soyuka Merci! For accepting the change 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents
OrderExtensionfor Doctrine ORM and MongoDbOdm to apply order to the collection if sorting is already defined on the queryBuilder/aggregationBuilder.#4523