fix: ensure OpenAPI-specific implementation for nullable types does not influence the other ones #4725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deuchnord
changed the title
Deuchnord
force-pushed
the
fix/4621-null-value-found
branch
from
c23981f to
be0380b
Compare
alanpoulain
reviewed
Apr 21, 2022
src/JsonSchema/TypeFactory.php
Outdated
| ]; | ||
| $typeDefinition = ['anyOf' => $jsonSchema]; | ||
|
|
||
| if ($schema && Schema::VERSION_OPENAPI === $schema->getVersion()) { |
There was a problem hiding this comment.
Please make sure you are in a JSON Schema context, not an OpenAPI one: nullable is not available for OpenAPI >= 3.1.
…ot influence the other ones
Deuchnord
force-pushed
the
fix/4621-null-value-found
branch
from
be0380b to
7301f27
Compare
alanpoulain
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug that prevents the
ApiPlatform\Core\Bridge\Symfony\Bundle\Test\ApiTestAssertionsTrait::assertMatchesResourceItemJsonSchema()method from validating against JSON-Schema correctly for some nullable properties.