-
-
Notifications
You must be signed in to change notification settings - Fork 933
fix(json-schema): factory backward compatibility layer #4758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e74e9b0
to
ff45fd8
Compare
b2fb737
to
9fa6940
Compare
@soyuka this seems to cause a break between v2.6 and v2.7 $this->assertMatchesResourceItemJsonSchema(PolicyNotice::class); works on 2.6 but breaks on 2.7 because 2.7 tries to "guess" the operation and can't find one, so creates a new one with the wrong (empty) serialization context. core/src/JsonSchema/SchemaFactory.php Line 284 in 4c16efe
in 2.7 i have to do this to fix it: $this->assertMatchesResourceItemJsonSchema(PolicyNotice::class, '_api_/policy-notices/{id}.{_format}_get'); this can't be intended, surely? |
…4758) * fix(json-schema): factory backward compatibility layer link api-platform#4753 * sdkjhg * php 7... * php 7... * php 7... * php 7... * fix * tired * come on * come on
…4758) * fix(json-schema): factory backward compatibility layer link api-platform#4753 * sdkjhg * php 7... * php 7... * php 7... * php 7... * fix * tired * come on * come on
…4758) * fix(json-schema): factory backward compatibility layer link api-platform#4753 * sdkjhg * php 7... * php 7... * php 7... * php 7... * fix * tired * come on * come on
link #4753