fix(metadata): add read and write to extractor #4760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
May 18, 2022
|
I'm thinking that there might me more missing attributes I think that we should just check that everything in |
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 29, 2022
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 29, 2022
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 29, 2022
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read and write attributes are missing for xml and yaml extractor