Skip to content

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Nov 21, 2022

fixes #5203

@soyuka soyuka merged commit 0f89161 into api-platform:3.0 Nov 23, 2022
@soyuka soyuka deleted the fix/metadata-route-prefix-operation-name branch November 23, 2022 08:30
@usu
Copy link
Contributor

usu commented Nov 26, 2022

Hi @soyuka. Thanks for looking into this. I tried to test this with my application, but didn't work:

  • Factories are decorated as per the following chain: OperationNameResourceMetadataCollectionFactory --> LinkResourceMetadataCollectionFactory --> UriTemplateResourceMetadataCollectionFactory

  • In UriTemplateResourceMetadataCollectionFactory on line 83, the operation name is already set (without routePrefix)

  • In OperationNameResourceMetadataCollectionFactory on line 47, the loop is aborted, because the name is already set. Hence, the new logic to include routePrefix is never executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants