chore(deprecation): Only use ValueResolverInterface if it exists #5324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm it still seems to load the old one, I'll look into why more tomorrow |
franmomu
reviewed
Jan 12, 2023
src/Symfony/Bundle/ArgumentResolver/PayloadArgumentResolver.php
Outdated
Show resolved
Hide resolved
soyuka
reviewed
Jan 12, 2023
src/Symfony/Bundle/ArgumentResolver/PayloadArgumentResolver.php
Outdated
Show resolved
Hide resolved
KDederichs
force-pushed
the
fix/value_resolver_interface
branch
from
3a7aa16 to
b94c87c
Compare
|
I like this approach better, can you rebase so that the CI runs lowest? |
…form#5314) * test: add reproducer for bug 5310 * fix(graphql): use depth for nested resource class operation Co-authored-by: Alan Poulain <contact@alanpoulain.eu>
|
Hmm looks like there's something else broken in the lowest tests (unrelated to this) |
KDederichs
force-pushed
the
fix/value_resolver_interface
branch
from
17ddc27 to
376e2ee
Compare
|
No problem, I see that and the exception related to this is gone! We should investigate the other issue in another patch. |
soyuka
added a commit
that referenced
this pull request
Jan 12, 2023
|
whoops the rebase was wrong I did that at #5334 When rebasing against a branch upstream: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #5289 , only use
ValueResolverInterfaceif it exists, use the old one otherwise