fix(graphql): name and key should be the same for an enum without Enum suffix in class name #5369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m suffix in class name
alanpoulain
force-pushed
the
fix/graphql-enum-name
branch
from
23d3d3a to
397d12d
Compare
|
Today I applied this fix to my codebase and I am not totally fine with it @alanpoulain. As a side effect all the enum types are also suffixed with I can workaround this on my clients. But wanted to let you know about it. So you can decide if this is OK or needs to be solved either. |
|
Why would it be a BC? It was not working before, so it should not considered a BC in my opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5367.