Skip to content

Conversation

syl20b
Copy link
Contributor

@syl20b syl20b commented Feb 8, 2023

Q A
Branch? 3.1
Tickets #5391
License MIT
Doc PR N/A

Inside the ApiPlatform\Serializer\AbstractConstraintViolationListNormalizer, Symfony\Component\Serializer\NameConverter\AdvancedNameConverterInterface::normalize signature is used, but Symfony\Component\Serializer\NameConverter\NameConverterInterface is used in the constructor declaration.

@syl20b syl20b force-pushed the fix/use-advanced-name-converter branch 3 times, most recently from f8b0b48 to ba6d5fe Compare February 8, 2023 18:49
@dunglas
Copy link
Member

dunglas commented Feb 8, 2023

This is technically a BC break. Couldn't we use instanceof to not call the methods defined in the advanced interface if not available instead?

@syl20b syl20b force-pushed the fix/use-advanced-name-converter branch 3 times, most recently from 5e3fe12 to c2fabfb Compare February 9, 2023 20:53
@syl20b syl20b force-pushed the fix/use-advanced-name-converter branch from c2fabfb to ea508ec Compare February 12, 2023 19:00
@syl20b
Copy link
Contributor Author

syl20b commented Feb 12, 2023

@soyuka I've added some tests.

@syl20b syl20b requested a review from soyuka February 16, 2023 11:32
@soyuka soyuka merged commit ff3255c into api-platform:3.1 Feb 28, 2023
@soyuka
Copy link
Member

soyuka commented Feb 28, 2023

thanks @syl20b !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants