FIX(metadata): In XmlResourceExtractor building request body content … #5419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraynaud1330
force-pushed
the
fix-xml-resource-extractor
branch
3 times, most recently
from
15ceb5e to
a96177d
Compare
soyuka
force-pushed
the
fix-xml-resource-extractor
branch
from
a96177d to
713ede9
Compare
soyuka
force-pushed
the
fix-xml-resource-extractor
branch
from
713ede9 to
6d63c27
Compare
|
thanks @fraynaud1330 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5402
Fix error in XmlResourceExtractor :
API Platform version(s) affected: 3.1.2
Description
When creating a custom operation with a specific request body in a resource in a XML file we have the following error :
In ResourceExtractorTrait.php line 91: Warning: foreach() argument must be of type array|object, null given
How to reproduce
Create a resource in a XML file with an operation with a specific request body
Possible Solution
Modification in the file src/Metadata/Extractor/XmlResourceExtractor.php line 218 change $this->buildValues($openapi->requestBody->values) to $this->buildValues($openapi->requestBody->content->values) : https://github.com/api-platform/core/blob/3.1/src/Metadata/Extractor/XmlResourceExtractor.php#L218