ci: fix tests

features/authorization/deny.feature

@@ -202,4 +202,3 @@ Feature: Authorization checking
     And I send a "GET" request to "/secured_dummies"
     Then the response status code should be 200
     And the response should contain "ownerOnlyProperty"
-

src/Core/Annotation/ApiFilter.php

@@ -54,7 +54,7 @@ final class ApiFilter
     public $arguments = [];
 
     /**
-     * @param string $filterClass
+     * @param mixed  $filterClass
      * @param string $id
      * @param string $strategy
      */
@@ -65,9 +65,9 @@ public function __construct(
         array $properties = [],
         array $arguments = []
     ) {
-        if (\is_array($filterClass)) { /** @phpstan-ignore-line Doctrine annotations */
+        if (\is_array($filterClass)) {
             $options = $filterClass;
-            $this->filterClass = $options['value'] ?? null; /* @phpstan-ignore-line Doctrine annotations */
+            $this->filterClass = $options['value'] ?? null;
             unset($options['value']);
 
             foreach ($options as $key => $value) {

src/Core/Annotation/ApiProperty.php

@@ -23,7 +23,9 @@
  * @Annotation
  *
  * @Target({"METHOD", "PROPERTY"})
+ *
  * @Attributes(
+ *
  *     @Attribute("deprecationReason", type="string"),
  *     @Attribute("fetchable", type="bool"),
  *     @Attribute("fetchEager", type="bool"),

src/Core/Annotation/ApiResource.php

@@ -23,7 +23,9 @@
  * @Annotation
  *
  * @Target({"CLASS"})
+ *
  * @Attributes(
+ *
  *     @Attribute("accessControl", type="string"),
  *     @Attribute("accessControlMessage", type="string"),
  *     @Attribute("attributes", type="array"),

src/Core/Annotation/ApiSubresource.php

@@ -21,7 +21,9 @@
  * @Annotation
  *
  * @Target({"METHOD", "PROPERTY"})
+ *
  * @Attributes(
+ *
  *     @Attribute("maxDepth", type="int"),
  * )
  */

src/Core/Identifier/IdentifierConverter.php

@@ -71,7 +71,7 @@ public function convert($data, string $class, array $context = []): array
                 try {
                     $identifiers[$parameter] = $identifierTransformer->denormalize($value, $type);
                     break;
-                } catch (InvalidIdentifierException $e) {
+                } catch (InvalidIdentifierException $e) { // @phpstan-ignore-line wrong choice of interface, was fixed in 3.0
                     throw new InvalidIdentifierException(sprintf('Identifier "%s" could not be denormalized.', $parameter), $e->getCode(), $e);
                 }
             }

src/JsonApi/Serializer/ItemNormalizer.php

@@ -237,7 +237,6 @@ protected function normalizeRelation($propertyMetadata, $relatedObject, string $
             }
 
             $normalizedRelatedObject = $this->serializer->normalize($relatedObject, $format, $context);
-            // @phpstan-ignore-next-line throwing an explicit exception helps debugging
             if (!\is_string($normalizedRelatedObject) && !\is_array($normalizedRelatedObject) && !$normalizedRelatedObject instanceof \ArrayObject && null !== $normalizedRelatedObject) {
                 throw new UnexpectedValueException('Expected normalized relation to be an IRI, array, \ArrayObject or null');
             }

src/Metadata/ApiFilter.php

@@ -82,7 +82,7 @@ public function __construct(
             $this->arguments = $arguments;
         }
 
-        if (!\is_string($this->filterClass)) {
+        if (!\is_string($this->filterClass)) { /* @phpstan-ignore-line Doctrine annotations */
             throw new InvalidArgumentException('This annotation needs a value representing the filter class.');
         }
 

src/Serializer/AbstractItemNormalizer.php

@@ -887,7 +887,6 @@ protected function normalizeRelation($propertyMetadata, $relatedObject, string $
             }
 
             $normalizedRelatedObject = $this->serializer->normalize($relatedObject, $format, $context);
-            // @phpstan-ignore-next-line throwing an explicit exception helps debugging
             if (!\is_string($normalizedRelatedObject) && !\is_array($normalizedRelatedObject) && !$normalizedRelatedObject instanceof \ArrayObject && null !== $normalizedRelatedObject) {
                 throw new UnexpectedValueException('Expected normalized relation to be an IRI, array, \ArrayObject or null');
             }

src/Serializer/CacheKeyTrait.php

@@ -34,11 +34,11 @@ private function getCacheKey(?string $format, array $context)
         unset($context['cache_key']); // avoid artificially different keys
 
         try {
-            return hash('xxh128', $format.serialize([
+            return hash('md5', $format.serialize([
                 'context' => $context,
                 'ignored' => $context[self::IGNORED_ATTRIBUTES] ?? $this->defaultContext[self::IGNORED_ATTRIBUTES],
             ]));
-        } catch (\Exception) {
+        } catch (\Exception $e) {
             // The context cannot be serialized, skip the cache
             return false;
         }

tests/Core/Annotation/ApiFilterTest.php

@@ -28,28 +28,28 @@ public function testInvalidConstructor()
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage('This annotation needs a value representing the filter class.');
 
-        new ApiFilter(null); // @phpstan-ignore-line
+        new ApiFilter(null);
     }
 
     public function testInvalidFilter()
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage('The filter class "ApiPlatform\\Tests\\Fixtures\\TestBundle\\Entity\\Dummy" does not implement "ApiPlatform\\Api\\FilterInterface". Did you forget a use statement?');
 
-        new ApiFilter(['value' => Dummy::class]); // @phpstan-ignore-line
+        new ApiFilter(['value' => Dummy::class]);
     }
 
     public function testInvalidProperty()
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage('Property "foo" does not exist on the ApiFilter annotation.');
 
-        new ApiFilter(['value' => DummyFilter::class, 'foo' => 'bar']); // @phpstan-ignore-line
+        new ApiFilter(['value' => DummyFilter::class, 'foo' => 'bar']);
     }
 
     public function testAssignation()
     {
-        $resource = new ApiFilter(['value' => DummyFilter::class, 'strategy' => 'test', 'properties' => ['one', 'two'], 'arguments' => ['args']]); // @phpstan-ignore-line
+        $resource = new ApiFilter(['value' => DummyFilter::class, 'strategy' => 'test', 'properties' => ['one', 'two'], 'arguments' => ['args']]);
 
         $this->assertEquals($resource->filterClass, DummyFilter::class);
         $this->assertEquals($resource->strategy, 'test');

tests/Core/Metadata/Resource/Factory/AnnotationResourceFilterMetadataFactoryTest.php

@@ -39,7 +39,7 @@ public function testCreate()
         $decorated->create(Dummy::class)->willReturn(new ResourceMetadata('hello', 'blabla'))->shouldBeCalled();
 
         $reader = $this->prophesize(Reader::class);
-        $reader->getClassAnnotations(Argument::type(\ReflectionClass::class))->shouldBeCalled()->willReturn([ // @phpstan-ignore-next-line
+        $reader->getClassAnnotations(Argument::type(\ReflectionClass::class))->shouldBeCalled()->willReturn([
             new ApiFilter(['value' => DummyFilter::class]),
         ]);
 

tests/Fixtures/DummyAtLeastOneOfValidatedEntity.php

@@ -21,7 +21,9 @@ class DummyAtLeastOneOfValidatedEntity
      * @var string
      *
      * @Assert\AtLeastOneOf({
+     *
      *     @Assert\Regex("/#/"),
+     *
      *     @Assert\Length(min=10)
      * })
      */

tests/Fixtures/DummyCollectionValidatedEntity.php

@@ -24,18 +24,25 @@ class DummyCollectionValidatedEntity
      *     allowExtraFields=true,
      *     fields={
      *         "name"=@Assert\Required({
+     *
      *             @Assert\NotBlank
      *         }),
      *         "email"={
+     *
      *             @Assert\NotNull,
+     *
      *             @Assert\Length(min=2, max=255),
+     *
      *             @Assert\Email(mode=Assert\Email::VALIDATION_MODE_LOOSE)
      *         },
      *         "phone"=@Assert\Optional({
+     *
      *             @Assert\Type(type="string"),
+     *
      *             @Assert\Regex(pattern="/^[+]*[(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\.\/0-9]*$/")
      *         }),
      *         "age"=@Assert\Optional({
+     *
      *             @Assert\Type(type="int")
      *         }),
      *         "social"=@Assert\Collection(

tests/Fixtures/DummySequentiallyValidatedEntity.php

@@ -21,7 +21,9 @@ class DummySequentiallyValidatedEntity
      * @var string
      *
      * @Assert\Sequentially({
+     *
      *     @Assert\Length(min=1, max=32),
+     *
      *     @Assert\Regex(pattern="/^[a-z]$/")
      * })
      */

tests/Fixtures/DummyValidatedEntity.php

@@ -31,7 +31,9 @@ class DummyValidatedEntity
      * @var string A dummy
      *
      * @Assert\NotBlank
+     *
      * @Assert\Length(max="4", min="10")
+     *
      * @Assert\Regex(pattern="/^dummy$/")
      */
     public $dummy;

tests/Fixtures/Elasticsearch/Model/Tweet.php

@@ -26,13 +26,15 @@
  *         "groups"={"tweet:read"}
  *     }
  * )
+ *
  * @ApiFilter(OrderFilter::class, properties={"id", "author.id"})
  * @ApiFilter(MatchFilter::class, properties={"message", "author.firstName"})
  */
 class Tweet
 {
     /**
      * @ApiProperty(identifier=true)
+     *
      * @Groups({"tweet:read", "user:read"})
      */
     private $id;

tests/Fixtures/Elasticsearch/Model/User.php

@@ -25,12 +25,14 @@
  *         "groups"={"user:read"}
  *     }
  * )
+ *
  * @ApiFilter(TermFilter::class, properties={"id", "gender", "age", "firstName", "tweets.id", "tweets.date"})
  */
 class User
 {
     /**
      * @ApiProperty(identifier=true)
+     *
      * @Groups({"user:read", "tweet:read"})
      */
     private $id;

tests/Fixtures/TestBundle/Document/AbsoluteUrlDummy.php

@@ -19,6 +19,7 @@
 
 /**
  * @ApiResource(urlGenerationStrategy=UrlGeneratorInterface::ABS_URL)
+ *
  * @ODM\Document
  */
 class AbsoluteUrlDummy

tests/Fixtures/TestBundle/Document/AbsoluteUrlRelationDummy.php

@@ -21,6 +21,7 @@
 
 /**
  * @ApiResource(urlGenerationStrategy=UrlGeneratorInterface::ABS_URL)
+ *
  * @ODM\Document
  */
 class AbsoluteUrlRelationDummy

tests/Fixtures/TestBundle/Document/AbstractDummy.php

@@ -28,9 +28,13 @@
  *     itemOperations={"get", "put", "delete"},
  *     attributes={"filters"={"my_dummy.mongodb.search", "my_dummy.mongodb.order", "my_dummy.mongodb.date"}}
  * )
+ *
  * @ODM\Document
+ *
  * @ODM\InheritanceType("SINGLE_COLLECTION")
+ *
  * @ODM\DiscriminatorField(value="discr")
+ *
  * @ODM\DiscriminatorMap({"concrete"=ConcreteDummy::class})
  */
 abstract class AbstractDummy
@@ -46,7 +50,9 @@ abstract class AbstractDummy
      * @var string The dummy name
      *
      * @ODM\Field
+     *
      * @Assert\NotBlank
+     *
      * @ApiProperty(iri="http://schema.org/name")
      */
     private $name;

tests/Fixtures/TestBundle/Document/Address.php

@@ -21,6 +21,7 @@
  * @ApiResource(
  *     attributes={"normalization_context"={"groups"={"order_read"}}}
  * )
+ *
  * @ODM\Document
  */
 class Address
@@ -29,12 +30,14 @@ class Address
      * @var int
      *
      * @ODM\Id(strategy="INCREMENT", type="int")
+     *
      * @Groups({"order_read"})
      */
     private $id;
 
     /**
      * @ODM\Field(type="string")
+     *
      * @Groups({"order_read"})
      */
     public $name;

tests/Fixtures/TestBundle/Document/Answer.php

@@ -24,6 +24,7 @@
  * Answer.
  *
  * @ODM\Document
+ *
  * @ApiResource(collectionOperations={
  *     "get_subresource_answer"={"method"="GET", "normalization_context"={"groups"={"foobar"}}}
  * })
@@ -32,24 +33,28 @@ class Answer
 {
     /**
      * @ODM\Id(strategy="INCREMENT", type="int")
+     *
      * @Serializer\Groups({"foobar"})
      */
     private $id;
 
     /**
      * @ODM\Field(nullable=false)
+     *
      * @Serializer\Groups({"foobar"})
      */
     private $content;
 
     /**
      * @ODM\ReferenceOne(targetDocument=Question::class, mappedBy="answer")
+     *
      * @Serializer\Groups({"foobar"})
      */
     private $question;
 
     /**
      * @ODM\ReferenceMany(targetDocument=Question::class, mappedBy="answer")
+     *
      * @Serializer\Groups({"foobar"})
      *
      * @ApiSubresource

tests/Fixtures/TestBundle/Document/ArrayFilterValidator.php

@@ -29,6 +29,7 @@
  *         ArrayRequiredFilter::class
  *     }
  * })
+ *
  * @ODM\Document
  */
 class ArrayFilterValidator
@@ -44,6 +45,7 @@ class ArrayFilterValidator
      * @var string A name
      *
      * @ODM\Field
+     *
      * @ApiProperty(iri="http://schema.org/name")
      */
     private $name;

tests/Fixtures/TestBundle/Document/Book.php

@@ -25,6 +25,7 @@
  *     "get",
  *     "get_by_isbn"={"method"="GET", "path"="/books/by_isbn/{isbn}.{_format}", "requirements"={"isbn"=".+"}, "identifiers"="isbn"}
  * })
+ *
  * @ODM\Document
  */
 class Book

tests/Fixtures/TestBundle/Document/CircularReference.php

@@ -24,6 +24,7 @@
  * @author Kévin Dunglas <dunglas@gmail.com>
  *
  * @ApiResource(attributes={"normalization_context"={"groups"={"circular"}}})
+ *
  * @ODM\Document
  */
 class CircularReference
@@ -35,12 +36,14 @@ class CircularReference
 
     /**
      * @ODM\ReferenceOne(targetDocument=CircularReference::class, inversedBy="children")
+     *
      * @Groups({"circular"})
      */
     public $parent;
 
     /**
      * @ODM\ReferenceMany(targetDocument=CircularReference::class, mappedBy="parent")
+     *
      * @Groups({"circular"})
      */
     public $children;

tests/Fixtures/TestBundle/Document/CompositeItem.php

@@ -33,12 +33,14 @@ class CompositeItem
 
     /**
      * @ODM\Field(type="string", nullable=true)
+     *
      * @Groups({"default"})
      */
     private $field1;
 
     /**
      * @ODM\ReferenceMany(targetDocument=CompositeRelation::class, mappedBy="compositeItem")
+     *
      * @Groups({"default"})
      */
     private $compositeValues;