fix(serializer): skip not found properties #5474
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/5464-return-bad-request
branch
2 times, most recently
from
f339d97 to
2d77e22
Compare
soyuka
force-pushed
the
fix/5464-return-bad-request
branch
from
2d77e22 to
46ccd4e
Compare
soyuka
changed the title
deguif
reviewed
Mar 20, 2023
| $propertyNames = iterator_to_array($this->propertyNameCollectionFactory->create($resourceClass, $options)); | ||
| // Revert attributes that aren't allowed to be changed after a post-denormalize check | ||
| foreach (array_keys($data) as $attribute) { | ||
| if (!\in_array($attribute, $propertyNames, true)) { |
There was a problem hiding this comment.
Suggested change
| if (!\in_array($attribute, $propertyNames, true)) { | |
| $attribute = $this->nameConverter ? $this->nameConverter->denormalize($attribute) : $attribute; | |
| if (!\in_array($attribute, $propertyNames, true)) { |
There was a problem hiding this comment.
Shouldn't the name converter be used to convert the attribute name to object property name?
|
we will actually fix that at #5495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…operty