fix(elasticsearch): add is_collection to documentation #5497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dannyvw
commented
Mar 24, 2023
dannyvw
commented
| Q | A |
|---|---|
| Branch? | 3.0 |
| Tickets | #... |
| License | MIT |
| Doc PR | api-platform/docs#... |
soyuka
reviewed
Mar 27, 2023
| 'property' => $property, | ||
| 'type' => $hasAssociation ? 'string' : $this->getPhpType($type), | ||
| 'required' => false, | ||
| 'is_collection' => str_ends_with((string) $filterParameterName, '[]'), |
There was a problem hiding this comment.
could we check the $type (or even $types) instead?
There was a problem hiding this comment.
This should only be applied for "{$property}[]" and the $type property does not have this information. I use the same implementation as is done for doctrine https://github.com/api-platform/core/blob/main/src/Doctrine/Common/Filter/SearchFilterTrait.php#L79
|
i need more time to investigate that, could you target 3.1 anyways? |
dannyvw
force-pushed
the
es-filter-description
branch
from
7e89129 to
7a04c5d
Compare
|
let's take this for now each time somethings has to do with filters I just want to improve them alltogether... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.