Skip to content

fix(symfony): check operations's parameters #5513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix(symfony): check operations's parameters #5513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/Symfony/Bundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
use ApiPlatform\Exception\FilterValidationException;
use ApiPlatform\Exception\InvalidArgumentException;
use ApiPlatform\Metadata\ApiResource;
use ApiPlatform\Metadata\Post;
use ApiPlatform\Metadata\Put;
use Doctrine\Bundle\DoctrineBundle\DoctrineBundle;
use Doctrine\Bundle\MongoDBBundle\DoctrineMongoDBBundle;
use Doctrine\ORM\EntityManagerInterface;
Expand Down Expand Up @@ -558,10 +560,9 @@ private function addDefaultsSection(ArrayNodeDefinition $rootNode): void
return $normalizedDefaults;
});

$reflection = new \ReflectionClass(ApiResource::class);
foreach ($reflection->getConstructor()->getParameters() as $parameter) {
$defaultsNode->children()->variableNode($nameConverter->normalize($parameter->getName()));
}
$this->defineDefault($defaultsNode, new \ReflectionClass(ApiResource::class), $nameConverter);
$this->defineDefault($defaultsNode, new \ReflectionClass(Put::class), $nameConverter);
$this->defineDefault($defaultsNode, new \ReflectionClass(Post::class), $nameConverter);
}

private function addMakerSection(ArrayNodeDefinition $rootNode): void
Expand All @@ -573,4 +574,11 @@ private function addMakerSection(ArrayNodeDefinition $rootNode): void
->end()
->end();
}

private function defineDefault(ArrayNodeDefinition $defaultsNode, \ReflectionClass $reflectionClass, CamelCaseToSnakeCaseNameConverter $nameConverter)
{
foreach ($reflectionClass->getConstructor()->getParameters() as $parameter) {
$defaultsNode->children()->variableNode($nameConverter->normalize($parameter->getName()));
}
}
}