Skip to content

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jun 2, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@dunglas
Copy link
Member Author

dunglas commented Jun 3, 2016

Travis failure related to FriendsOfSymfony/FOSUserBundle#2148

.travis.yml Outdated
- php: hhvm

before_install:
- if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then phpenv config-rm xdebug.ini; fi;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the phpenv config-rm xdebug.ini is no longer required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xdebug is still enabled by default on Travis, so we should keep this.

@teohhanhui
Copy link
Contributor

@dunglas Did you accidentally push into this branch? Because the title doesn't make sense considering #631...

@dunglas
Copy link
Member Author

dunglas commented Aug 19, 2016

It wasn't accidentally, I'm still working on prefer-lowest support.

.travis.yml Outdated
- php: '7.0'
env: PREFER_LOWEST=""
- php: '7.1'
env: PREFER_LOWEST="--prefer-lowest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use COMPOSER_FLAGS instead so you don't have to declare it for the first build instead of PREFER_LOWEST=""

@dunglas dunglas changed the title Don't test with HHVM. Test with lowest dependencies. Test with lowest dependencies and PHP 7.1 Aug 19, 2016
@dunglas dunglas force-pushed the travis branch 2 times, most recently from ee54a59 to e310552 Compare August 19, 2016 20:30
@dunglas
Copy link
Member Author

dunglas commented Aug 19, 2016

It looks like 7.1 is very unstable now (seg fault). I'll focus on the lowest dependencies test for now.

@dunglas dunglas changed the title Test with lowest dependencies and PHP 7.1 Test with lowest dependencies Aug 19, 2016
@dunglas dunglas merged commit 7e25a2a into master Aug 19, 2016
@dunglas dunglas deleted the travis branch August 19, 2016 23:28
magarzon pushed a commit to magarzon/core that referenced this pull request Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants