fix: enable to update all keys in metadata #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jul 21, 2023
| @@ -95,10 +95,27 @@ private function update(ApiProperty $propertyMetadata, array $metadata): ApiProp | |||
| 'description' => 'get', | |||
| 'readable' => 'is', | |||
| 'writable' => 'is', | |||
| 'writableLink' => 'is', | |||
There was a problem hiding this comment.
Can you don't move existing keys (to ease merge commits) please?
ttskch
force-pushed
the
fix/extractor-property-metadata-factory
branch
from
5e1fd4f to
624105c
Compare
|
Thanks @ttskch! |
xavierleune
pushed a commit
to xavierleune/api-platform
that referenced
this pull request
Jul 22, 2023
Romaixn
pushed a commit
to Romaixn/core
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5482.
Because
ExtractorPropertyMetadataFactory::update()method was updating only some of the properties of theApiPropertyclass, so in decorated factories, metadata such asopenapiContextwere not being updated.