Skip to content

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jun 7, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@soyuka
Copy link
Member

soyuka commented Jun 7, 2016

Weird appveyor bug when installing deps:

phpDocumentor\Reflection\DocBlock\Tags\BaseTag cannot implement phpDocumentor\Reflection\DocBlock\Tag - it is not an interface in C:\projects\dunglas\api-bundle\vendor\phpdocumentor\reflection-docblock\src\DocBlock\Tags\BaseTag.php on line 21

@dunglas
Copy link
Member Author

dunglas commented Jun 7, 2016

@soyuka because it still use the built-in phpunit (which isn't up to date) instead of the one installed by Composer. I'll fix that.

@teohhanhui
Copy link
Contributor

We must add phpunit/phpunit to require-dev. Currently it's only a coincidence that this works (transitive dependency through php-mock/php-mock-phpunit).

@dunglas
Copy link
Member Author

dunglas commented Jun 8, 2016

@teohhanhui you're right, and we must remove it when a new release of the PHPUnit phar will be released.

@teohhanhui
Copy link
Contributor

@dunglas The PHPUnit phar is already at 5.4.2

What am I missing?

@dunglas
Copy link
Member Author

dunglas commented Jun 8, 2016

The PHPUnit PHAR doesn't include Prophecy 1.6.1 yet (and previous versions are buggy with Symfony 3.1).

@teohhanhui
Copy link
Contributor

Requested here: sebastianbergmann/phpunit#2201 (comment)

@dunglas dunglas merged commit cde69f8 into master Jun 8, 2016
@dunglas dunglas deleted the prophecy branch June 8, 2016 21:05
magarzon pushed a commit to magarzon/core that referenced this pull request Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants