fix(openapi): correctly output OpenAPI parameters #5703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, may you add a non regression test? Also your commit scope could be: |
ttskch
force-pushed
the
fix/openapi-parameters
branch
from
b91931c to
8a56290
Compare
ttskch
changed the title
|
Sorry, I have already confirmed that using Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes following bug:
When parameters are set in openapiContext for some operations with some filters applied, the filter parameters are lost and only the parameters set in openapiContext are output to OpenAPI.
The cause of this bug was as follows. Even though the pagination and filter parameters are merged at here, they are reset to openapiContext parameters value at here.