feat: allow upgrading single resource #5768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Aug 23, 2023
src/Core/Bridge/Symfony/Bundle/Command/UpgradeApiResourceCommand.php
Outdated
Show resolved
Hide resolved
src/Core/Bridge/Symfony/Bundle/Command/UpgradeApiResourceCommand.php
Outdated
Show resolved
Hide resolved
n-valverde
force-pushed
the
feat/upgrade-single-api-resource
branch
from
adfa431 to
da436e1
Compare
|
Hello @soyuka , thanks for the review, all fixed, do you think a doc PR is actually required? |
|
It's fine like this, red ci is because of 2.7 starting to be hard to maintain though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, want to propose a small improvement for the
api:upgrade-resourcecommand.I'm fine if you don't want to merge this since it's not a fix in any way, it's just something that comes very useful in our upgrade scenario, so could probably be useful for others aswell.
Why? Because when upgrading a big application, you most likely want to take small steps, i.e. not running the upgrade on 200 resources in one shot, because there is a lot of things to refactor when upgrading a resource (providers, persisters, etc...).
Usage:
bin/console api:upgrade-resource Foo\\Bar\\BazLet me know if you agree to merge it so I can make a doc PR, thanks!