Skip to content

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Aug 23, 2023

Q A
Branch? main
Tickets N/A
License MIT
Doc PR N/A (@internal and @experimental)

Improve CreateProvider with parent_uri_template context option, and remove the new Get. If no parent_uri_template option is provided, get the first operation found as it's already done in core.

  • Set CreateProvider as @internal.
  • Inject CallableProvider instead of Doctrine ItemProvider in CreateProvider
  • Retrieve parent operation using parent_uri_template, or first operation available by default

@vincentchalamon vincentchalamon force-pushed the feat/create-provider-uri-template branch from add67e4 to 5689ae1 Compare August 23, 2023 12:52
@vincentchalamon vincentchalamon marked this pull request as ready for review August 23, 2023 12:59
@vincentchalamon vincentchalamon requested a review from soyuka August 23, 2023 12:59
soyuka

This comment was marked as resolved.

@vincentchalamon vincentchalamon force-pushed the feat/create-provider-uri-template branch from 5689ae1 to f1aa841 Compare August 29, 2023 06:54
@vincentchalamon vincentchalamon changed the base branch from 3.1 to main August 29, 2023 06:54
@vincentchalamon vincentchalamon force-pushed the feat/create-provider-uri-template branch from f1aa841 to 38c5d61 Compare August 29, 2023 07:13
@soyuka soyuka merged commit 0d04f28 into api-platform:main Sep 8, 2023
@vincentchalamon vincentchalamon deleted the feat/create-provider-uri-template branch September 8, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants