Skip to content

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jun 13, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #506
License MIT
Doc PR todo

Use a chain instead of a decorator for data providers. It allows to register custom data providers in a more intuitive fashion: just add a tag to your service.

ping @soyuka

@soyuka
Copy link
Member

soyuka commented Jun 13, 2016

Nice! Thx ❤️ .

/**
* @param CollectionDataProviderInterface[] $collectionDataProviders
*/
public function __construct(array $collectionDataProviders)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$dataProviders?

@theofidry
Copy link
Contributor

👍

@dunglas dunglas force-pushed the chain_data_provider branch from 34d8d57 to 4af55e1 Compare June 15, 2016 09:45
@dunglas dunglas merged commit 24f53ca into master Jun 16, 2016
@dunglas dunglas deleted the chain_data_provider branch June 16, 2016 06:18
magarzon pushed a commit to magarzon/core that referenced this pull request Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants