Skip to content

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Sep 11, 2023

@soyuka soyuka force-pushed the fix-jsonschema branch 2 times, most recently from cbecbc9 to e03bb31 Compare September 12, 2023 09:28
@paullallier
Copy link
Contributor

paullallier commented Sep 12, 2023

That looks a lots better! A couple things I still see:

There's something odd about the reference back from TestEntity --> BagOfTests in my example. I don't ever use this in my API, so it might be normal - not sure.
Screenshot 2023-09-12 at 10 44 44

Also, I haven't defined the return structure on errors. In alpha2, it didn't try to display them but in this branch it is displaying as something undefined. This might be a feature of the updated SwaggerUI, and it might not be a bad things, since I probably should defined the error return... Though perhaps I shouldn't need to do this explicitly?

In my dev environment, I have the API configured to display on https://main-api (it also displays on https://main-api/docs). In alpha2, it works. In this branch, I get raw json (LD, I think) on https://main-api (the /docs version gives the expect html).

@paullallier
Copy link
Contributor

paullallier commented Sep 12, 2023

Oh, and I think that was with e03bb31 No, it was cbecbc9

@soyuka soyuka force-pushed the fix-jsonschema branch 3 times, most recently from abe7770 to 5e7368a Compare September 12, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants