chore: allow psr/container v1 #5811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendavies
force-pushed
the
relax-symfony-service-contracts-constraint
branch
from
0198509 to
66d3af7
Compare
bendavies
changed the title
bendavies
force-pushed
the
relax-symfony-service-contracts-constraint
branch
from
50c4a36 to
ec4f380
Compare
|
Thanks @bendavies ! |
|
thankyou @soyuka ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm targeting 3.1 branch here as I'm classing (hope you will too!) as a bug fix.
This PR allows
api-platformto be installed alongsidepsr/container:v1At the moment, only
psr/container:v2is supported due to the conflict onsymfony/service-contractsadded here.This change was unnessearily restrictive, was probably the wrong fix at the time, and currently and CI passes with this change reverted anyway.
My motivation for this change is that api platform 3.1 is not installable alongside the current version of laminas/laminas-servicemanager (and thus any other
laminaspackages which depend onservice-manager), and due to the popularity of laminas packages, this isn't good.I also needed to bump the minimum supported version of behat to at least 3.11 for this fix.
The Behat minimum version was set to 3.1 which was released in 2016.
We could futher bump from ^3.11 to the latest here?