Skip to content

fix(FilterContext): add xxx[] hydra:search iexact #5850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2023
Merged

fix(FilterContext): add xxx[] hydra:search iexact #5850

merged 3 commits into from
Sep 28, 2023

Conversation

CorentinFackeure
Copy link
Contributor

@CorentinFackeure CorentinFackeure commented Sep 25, 2023 •
edited
Loading

Q A
Branch? 3.1
Tickets 5851
License MIT

@CorentinFackeure CorentinFackeure mentioned this pull request Sep 25, 2023
Closed
dunglas
dunglas approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be even better with a non-regression test 😃

Thanks for the fix and for your commitment.

@vincentchalamon vincentchalamon merged commit 6b84a66 into api-platform:3.1 Sep 28, 2023
@vincentchalamon
Copy link
Contributor

Thanks @CorentinFackeure!

bendavies
bendavies reviewed Oct 16, 2023
View reviewed changes
src/Doctrine/Common/Filter/SearchFilterInterface.php
/**
* @var string The value must be contained in the field case-insensitive
*/
public const STRATEGY_IPARTIAL = 'partial';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't thisd be ipartial?

@bendavies bendavies mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas dunglas approved these changes

@vincentchalamon vincentchalamon vincentchalamon approved these changes

+1 more reviewer

@bendavies bendavies bendavies left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CorentinFackeure @vincentchalamon @dunglas @bendavies