fix(jsonschema): do not override nor complete ApiProperty::schema user value

src/JsonSchema/SchemaFactory.php

@@ -13,6 +13,7 @@
 
 namespace ApiPlatform\JsonSchema;
 
+use ApiPlatform\JsonSchema\Metadata\Property\Factory\SchemaPropertyMetadataFactory;
 use ApiPlatform\Metadata\ApiProperty;
 use ApiPlatform\Metadata\CollectionOperationInterface;
 use ApiPlatform\Metadata\Exception\OperationNotFoundException;
@@ -158,6 +159,15 @@ private function buildPropertySchema(Schema $schema, string $definitionName, str
             $additionalPropertySchema ?? []
         );
 
+        $extraProperties = $propertyMetadata->getExtraProperties() ?? [];
+        // see AttributePropertyMetadataFactory
+        if (true === ($extraProperties[SchemaPropertyMetadataFactory::JSON_SCHEMA_USER_DEFINED] ?? false)) {
+            // schema seems to have been declared by the user: do not override nor complete user value
+            $schema->getDefinitions()[$definitionName]['properties'][$normalizedPropertyName] = new \ArrayObject($propertySchema);
+
+            return;
+        }
+
         $types = $propertyMetadata->getBuiltinTypes() ?? [];
 
         // never override the following keys if at least one is already set

tests/Fixtures/TestBundle/Entity/Issue5793/BagOfTests.php

@@ -42,6 +42,7 @@ class BagOfTests
 
     #[ORM\OneToMany(mappedBy: 'bagOfTests', targetEntity: TestEntity::class)]
     #[Groups(['read', 'write'])]
+    #[ApiProperty(schema: ['type' => 'string'], jsonSchemaContext: ['foo' => 'bar'])]
     private Collection $tests;
 
     #[ORM\OneToMany(mappedBy: 'bagOfTests', targetEntity: NonResourceTestEntity::class)]

tests/JsonSchema/Command/JsonSchemaGenerateCommandTest.php

@@ -104,10 +104,8 @@ public function testArraySchemaWithReference(): void
         $json = json_decode($result, associative: true);
 
         $this->assertEquals($json['definitions']['BagOfTests.jsonld-write']['properties']['tests'], [
-            'type' => 'array',
-            'items' => [
-                '$ref' => '#/definitions/TestEntity.jsonld-write',
-            ],
+            'type' => 'string',
+            'foo' => 'bar',
         ]);
 
         $this->assertEquals($json['definitions']['BagOfTests.jsonld-write']['properties']['nonResourceTests'], [