Skip to content

fix(serializer): allow usage of genId property for collection #5858 #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix(serializer): allow usage of genId property for collection #5858 #5870

merged 1 commit into from
Oct 6, 2023

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Oct 6, 2023

@soyuka soyuka force-pushed the genid-collections branch 2 times, most recently from 115efd3 to 6b8384f Compare October 6, 2023 07:30
@soyuka soyuka force-pushed the genid-collections branch from 6b8384f to a8eb9a6 Compare October 6, 2023 08:54
gaetan-petit
gaetan-petit approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@gaetan-petit gaetan-petit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing the tests @soyuka 🙏

@soyuka
Copy link
Member Author

soyuka commented Oct 6, 2023

credits to @Sarahshr

@soyuka soyuka merged commit c76d9b0 into api-platform:main Oct 6, 2023
@soyuka
Copy link
Member Author

soyuka commented Oct 6, 2023

note that this will be in 3.2 not 3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gaetan-petit gaetan-petit gaetan-petit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soyuka @gaetan-petit