Pass the context to IriConverter in AbstractItemNormalizer #5908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
pass-context-to-iri-converter
branch
5 times, most recently
from
47862d4 to
f63ff78
Compare
GSadee
force-pushed
the
pass-context-to-iri-converter
branch
from
f63ff78 to
66c19b7
Compare
lchrusciel
approved these changes
Oct 24, 2023
TheMilek
added a commit
to Sylius/Sylius
that referenced
this pull request
Nov 6, 2023
| Q | A | |-----------------|--------------------------------------------------------------| | Branch? | api-platform-3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | [5908](api-platform/core#5908) | License | MIT
GSadee
pushed a commit
to Sylius/SyliusApiBundle
that referenced
this pull request
Nov 14, 2023
| Q | A | |-----------------|--------------------------------------------------------------| | Branch? | api-platform-3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | [5908](api-platform/core#5908) | License | MIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the project I am working on (Sylius), we need to return the appropriate IRI depending on the section we are in. To achieve this I decorated the IriConverter and based the logic on the request information I had in the context. Unfortunately, in one of the places where the IriConverter is called, I found that the context is not being passed.