Skip to content

fix(graphql): service missing in debug mode #5930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix(graphql): service missing in debug mode #5930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,13 +583,16 @@ private function registerGraphQlConfiguration(ContainerBuilder $container, array
$container->registerForAutoconfiguration(ErrorHandlerInterface::class)
->addTag('api_platform.graphql.error_handler');

if (!$container->getParameter('kernel.debug')) {
return;
}

/* TODO: remove these in 4.x only one resolver factory is used and we're using providers/processors */
if ($config['event_listeners_backward_compatibility_layer'] ?? true) {
// @TODO: API Platform 3.3 trigger_deprecation('api-platform/core', '3.3', 'In API Platform 4 only one factory "api_platform.graphql.resolver.factory.item" will remain. Stages are deprecated in favor of using a provider/processor.');
// + deprecate every service from legacy/graphql.xml
$loader->load('legacy/graphql.xml');

if (!$container->getParameter('kernel.debug')) {
return;
}

$requestStack = new Reference('request_stack', ContainerInterface::NULL_ON_INVALID_REFERENCE);
$collectionDataCollectorResolverFactory = (new Definition(DataCollectorResolverFactory::class))
->setDecoratedService('api_platform.graphql.resolver.factory.collection')
Expand Down
11 changes: 11 additions & 0 deletions tests/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,4 +1274,15 @@ public function testLegacyGraphQlConfigurationWithoutJsonFormat(): void
(new ApiPlatformExtension())->load($config, $this->container);
$this->assertArrayHasKey('json', $this->container->getParameter('api_platform.formats'));
}

/**
* @see https://github.com/api-platform/core/issues/5919
*/
public function testGraphQlLegacyConfigurationInDebugMode(): void
{
$config = self::DEFAULT_CONFIG;

(new ApiPlatformExtension())->load($config, $this->container);
$this->assertTrue($this->container->hasDefinition('api_platform.graphql.resolver.factory.item'));
}
}