GraphQL: Errors with nullish ManyToOne-Relation when using new ResolverFactory #6084
Conversation
jotwea
force-pushed
the
resolver-factory
branch
2 times, most recently
from
1beabf6 to
6e82a2e
Compare
| } | ||
|
|
||
| if (null === $resourceClass && \array_key_exists($info->fieldName, $source ?? [])) { | ||
| if ((null === $resourceClass || !is_iterable($body)) && \array_key_exists($info->fieldName, $source ?? [])) { |
There was a problem hiding this comment.
Meanwhile I found a working solution: this tiny change fixes the issue with null values.
There was a problem hiding this comment.
shouldn't we check the PropertyMetadata type for this?
jotwea
force-pushed
the
resolver-factory
branch
from
6e82a2e to
6e09f50
Compare
|
you can target the lowest branch, 3.x are merged back |
| public function __invoke(string $resourceClass = null, string $rootClass = null, Operation $operation = null): callable | ||
| { | ||
| return function (?array $source, array $args, $context, ResolveInfo $info) use ($resourceClass, $rootClass, $operation) { | ||
| // special treatment for nested resources without a resolver/provider |
There was a problem hiding this comment.
mhh this line is from the other PR right?
There was a problem hiding this comment.
Yes. It was introduced by other PR. I moved this block one level up, though it also gets called when nested collection is null
There was a problem hiding this comment.
I created another PR based on 3.2 that only contains the bugfix relevant for 3.2. This one here also contains the null-fix for the recently introduced "nested collection" feature
jotwea
force-pushed
the
resolver-factory
branch
2 times, most recently
from
862764f to
ce02d7f
Compare
jotwea
force-pushed
the
resolver-factory
branch
3 times, most recently
from
43fb7ac to
e9ace4f
Compare
jotwea
force-pushed
the
resolver-factory
branch
from
e9ace4f to
f69ae8d
Compare
|
thanks cherry-picked |
2 participants
This PR introduces a new the test case especially for properties and Many-To-One-Relations being
null. It fixes the issues relevant for 3.2 and additionally provides a fix for the nested collection feature which was recently introduced on the main branch. There is another PR #6092 that contains only the fixes relevant for 3.2.