fix: add CollectionNormalizerTest && ItemNormalizerTest && ApiDocumentationBuilderTest #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Simperfit
commented
Jul 14, 2016
Simperfit
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Fixed tickets | |
| License | MIT |
| Doc PR |
Simperfit
force-pushed
the
feature/add-hydra-test
branch
3 times, most recently
from
64296e8 to
282a2b2
Compare
| class ItemNormalizerTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| /** | ||
| * @expectedException \ReflectionException |
|
I left some minor comments! Thank you very much for improving our test coverage. |
Simperfit
force-pushed
the
feature/add-hydra-test
branch
from
48f9c1e to
3cf292e
Compare
|
@dunglas comments addressed |
Simperfit
changed the title
Simperfit
force-pushed
the
feature/add-hydra-test
branch
from
fedca3e to
5016948
Compare
Simperfit
force-pushed
the
feature/add-hydra-test
branch
from
5016948 to
f45abe6
Compare
|
@dunglas ApiDocumentationBuilder Test added. |
Simperfit
force-pushed
the
feature/add-hydra-test
branch
from
5a4b4aa to
a068efc
Compare
|
Thank you @Simperfit |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
…test fix: add CollectionNormalizerTest && ItemNormalizerTest && ApiDocumentationBuilderTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.