feat(jsonschema): JSON:API schema factory #6250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Mar 29, 2024
Comment on lines
+107
to
+109
| if ($this->schemaFactory instanceof SchemaFactoryAwareInterface) { | ||
| $this->schemaFactory->setSchemaFactory($this); | ||
| } |
There was a problem hiding this comment.
This mirrors the changes made in #6236
soyuka
reviewed
Mar 29, 2024
soyuka
reviewed
Mar 29, 2024
soyuka
changed the title
|
nice, I merged 3.2 to main |
GwendolenLynch
force-pushed
the
feature/jsonapi-schema-factory
branch
2 times, most recently
from
bbeea72 to
f96846a
Compare
soyuka
reviewed
Mar 29, 2024
GwendolenLynch
force-pushed
the
feature/jsonapi-schema-factory
branch
from
f96846a to
dcb54c7
Compare
|
huge! thanks! |
|
Thanks to you too! Have a great weekend! 🎉 |
1 task
This was referenced Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This depends on recent commits in3.2that haven't been merged down tomainyet. So it is submitted against3.2and will be rebased & updated to targetmainafter said branch merge.