Add support for the API Error format (RFC 7807) and more tests #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Jul 16, 2016
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| And the JSON should be equal to: | ||
| """ | ||
| { | ||
| "type": "https://tools.ietf.org/html/rfc2616#section-10", |
There was a problem hiding this comment.
RFC 2616 is obsolete. See RFC 7231 instead.
There was a problem hiding this comment.
So this should be (if we use specific URIs for each status code):
"type": "https://tools.ietf.org/html/rfc7231#section-6.5.1"p/s: The indentation in this section is wrong (3 spaces instead of the intended 4)
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Add support for the API Error format (RFC 7807) and more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.