feat: complete util namespace tests #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
force-pushed
the
feature/add-test-for-util-namespace
branch
from
340c087 to
37722b1
Compare
|
Thanks Hamza! |
|
Can we stick to the colloquial "foo", "bar", "baz" (at least prefer these first) for meaningless identifiers and strings please? |
|
@teohhanhui we had the same debate several times for Symfony and I still don't get the why. Using funny (but still non discriminational) strings humanizes the project and has no drawback. |
|
It's harder to parse mentally... 😄 Especially since "foo", "bar", "foobar" etc. are easily recognizable to most developers. |
|
I like to humanizes the project too, then I can say to people look, we added this in ApiPlatform, isn't it funny ? non-developers recognize that too ;). |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
…or-util-namespace feat: complete util namespace tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add corverage to the Util Namespace