Refactor Swagger paths generation #698
Conversation
|
LGTM, thanks @teohhanhui |
| private function getPath(string $resourceShortName, array $operation, bool $collection) : string | ||
| { | ||
| $path = $this->operationPathResolver->resolveOperationPath($resourceShortName, $operation, $collection); | ||
| if (substr($path, -10) === '.{_format}') { | ||
| if ('.{_format}' === substr($path, -10)) { |
There was a problem hiding this comment.
It looks not very solid to rely on such hardcoded values (missed it on previous PRs). Anyway, it's not related with this PR and can be fixed in another PR.
There was a problem hiding this comment.
Yes, there are many other issues I've identified. But this PR is just for refactoring / better code quality.
|
Looks good to me 👍. By curiosity, why do you use |
Because PHP sucks. Also, I see that we might want to turn these into VOs so this is a good first step? |
teohhanhui
force-pushed
the
fix-swagger
branch
from
0183a98 to
56ab5bb
Compare
|
Thanks @teohhanhui |
Refactor Swagger paths generation
Some refactoring but also fixed
$operation['swagger_context']handling by checking for existing values./cc @Simperfit