chore: remove 3.4 deprecation #7204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
force-pushed
the
remove-deprecation
branch
4 times, most recently
from
456da73 to
f870421
Compare
|
should we target main instead for these? I'm not sure we cover the bc on every parameters that get removed in this patch |
|
I think that apart from what concerns the json format for OpenAPI (which breaks the tests btw), the rest can stay in 4.1. |
|
yes this would be perfect! Also could you point me to why we remove the graphql-playground ? |
maxhelias
force-pushed
the
remove-deprecation
branch
from
f870421 to
0142f0c
Compare
|
To keep only GraphiQL : #5309 |
|
Thanks a lot @maxhelias ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must be the last deprecation :
phpdocumentor/reflection-docblockin favor ofphpstan/phpdoc-parser